search

pcdshub / engineering_tools

A repository of scripts, configuration useful for the PCDS team
Other
4 stars 26 forks source link

Fixing epicsarch bug on last alias not having a pv #221

Closed KaushikMalapati closed 5 days ago

KaushikMalapati commented 1 week ago

Description

Probably should have included this in #219 I'm just checking if key is not empty after the for loop in read_file. If it is, that means we did not encounter a pv after the last alias, and it should be in extraKeys, but was not because the for loop only does so when it encounters the next key (a line that starts with * when key is not empty), which does not work on the last alias.

Motivation and Context

220

How Has This Been Tested?

Interactively with variations of this arch file

*Port_0_MCP_Front
TMO:MPOD:01:M0:C0:VoltageMeasure ca

*Port_1_MCP_Front
#TMO:MPOD:01:M0:C1:VoltageMeasure ca

#test

Where Has This Been Documented?

n/a

tangkong commented 5 days ago

For the record (hah) I think it's more apt as two separate PRs, they're accomplishing two different tasks 👍