search

pcdshub / happi

Heuristic Access to Positions of Photon Instruments
https://pcdshub.github.io/happi/master
Other
13 stars 29 forks source link

CLI API break: --json is now --show_json #288

Closed klauer closed 2 years ago

klauer commented 2 years ago

Code

https://github.com/pcdshub/happi/blob/dc37705ab2ae93fc2f88bd67f5a771e7f80c8a28/happi/cli.py#L77

Issue

This was --json and now it's --show_json without proper deprecation of the original

Separately, if "show json" is deemed preferable, this should probably be --show-json to be more CLI-friendly.

tangkong commented 2 years ago

Restoring --json in addition to --show_json is easy enough, I can lump that into the audit PR.

tangkong commented 2 years ago

closed by #286