Closed ZLLentz closed 1 year ago
In general, github workflow dependencies should be used sparingly (for things ONLY needed in the CI) because otherwise they obfuscate true package requirements.
Test requirements belong in two places: https://github.com/pcdshub/happi/blob/861496e5b40e7ad2fc4be6bdbfb0a53073b4247b/conda-recipe/meta.yaml#L42-L45 https://github.com/pcdshub/happi/blob/861496e5b40e7ad2fc4be6bdbfb0a53073b4247b/dev-requirements.txt
pcdsdevices and pcdsutils are included in the workflow only: https://github.com/pcdshub/happi/blob/861496e5b40e7ad2fc4be6bdbfb0a53073b4247b/.github/workflows/standard.yml#L19
Move them over
Expected Behavior
In general, github workflow dependencies should be used sparingly (for things ONLY needed in the CI) because otherwise they obfuscate true package requirements.
Test requirements belong in two places: https://github.com/pcdshub/happi/blob/861496e5b40e7ad2fc4be6bdbfb0a53073b4247b/conda-recipe/meta.yaml#L42-L45 https://github.com/pcdshub/happi/blob/861496e5b40e7ad2fc4be6bdbfb0a53073b4247b/dev-requirements.txt
Current Behavior
pcdsdevices and pcdsutils are included in the workflow only: https://github.com/pcdshub/happi/blob/861496e5b40e7ad2fc4be6bdbfb0a53073b4247b/.github/workflows/standard.yml#L19
Possible Solution
Move them over