pcdshub / happi

Heuristic Access to Positions of Photon Instruments
https://pcdshub.github.io/happi/master
Other
13 stars 29 forks source link

BUG: fix happi transfer default handling #335

Closed tangkong closed 1 year ago

tangkong commented 1 year ago

Description

Fix happi transfer default handling (don't past default help text) adds a test to try and cover this

Also fixes conftest.trim_split_output because it just.. entirely didn't work. More shame

In a burst of extra effort, disables assertion checks against expected stdout-style output. The check still takes place, but simply prints (visible with pytest -s flag) if a mismatch is found. In place of this, the happi_cfg is checked to verify the requested action has actually taken place.

Tests modified are:

Motivation and Context

closes #334 , in part (the non-list / dict comprehension parts)

How Has This Been Tested?

Adds a test

Where Has This Been Documented?

This PR

Pre-merge checklist