TST: Properly test with pymongo, adjust profiler usage for py3.12 - Githubissues

pcdshub / happi

Heuristic Access to Positions of Photon Instruments

https://pcdshub.github.io/happi/master

Other

13 stars 29 forks source link

TST: Properly test with pymongo, adjust profiler usage for py3.12 #346

Closed tangkong closed 3 months ago

tangkong commented 3 months ago

Description

Properly mark test_multi_backend as needing pymongo. (its fixtures had this decorator already, but the test still tried to run 🤷 )

Motivation and Context

Seen in #343 and others

How Has This Been Tested?

CI

Where Has This Been Documented?

This PR

Pre-merge checklist

[x] Code works interactively
[x] Code contains descriptive docstrings, including context and API
[x] New/changed functions and methods are covered in the test suite where possible
[x] Test suite passes locally
[x] Test suite passes on GitHub Actions
[x] Ran docs/pre-release-notes.sh and created a pre-release documentation page
[x] Pre-release docs include context, functional descriptions, and contributors as appropriate

tangkong commented 3 months ago

Python 3.12 slightly changed how the built-in cprofiler behaves. Now the following raises an error:

import cProfile

p1 = cProfile.Profile()
p1.enable()

p2 = cProfile.Profile()
# previously, p1 is silently disabled here, now python raises
p1.disable()
p2.enable()

(a very helpful comment)

The py3.12 tests only fail on the cprofile test cases, which is consistent with this issue