pcdshub / las-dispersion-scan

pypret-based laser dispersion scan tools and user interface
Other
0 stars 3 forks source link

XCS trial run suggestions / TODO #6

Closed klauer closed 1 year ago

klauer commented 2 years ago
slactjohnson commented 2 years ago

Additional feedback/info from testing 11/3:

klauer commented 1 year ago

Fix percent complete; progress bar goes to 100% and then hangs for a while

This hangs because matplotlib plots are rather slow. I suppose it could be hidden prior to the updates, but the UI will still lag.

Scan padding does weird things when the wavelength range is smaller than the padding. This should be set to zero.

Should this be configurable or always just 0? (Zeroed out in commit 0482d77)

slactjohnson commented 1 year ago

I figured as much, not a big deal; the progress bar can be ignored.

I think this can be zero always.

klauer commented 1 year ago

Add ability to plot the reconstructed pulse at any motor position in the scan. Sometimes they want to know the pulse length at some other off-optimum position.

~I thought it would be obvious in the code which array to plot, but it wasn't.~

I think I've got it - it requires re-retrieval of the pulse though from what I can tell. So it's in the appropriate spot in the GUI.

klauer commented 1 year ago

Almost all of these are done. I'll open a new issue just about the remaining tooltip thing