pcdshub / lcls-plc-crixs-motion

Repository for code related to the LCLS NEH H2.2 ChemRIXS endstation motion system.
https://pcdshub.github.io/lcls-plc-crixs-motion/
Other
0 stars 7 forks source link

Linking IO, adding counters and logic #67

Closed wnwright closed 1 year ago

wnwright commented 1 year ago

The SDS X stage limits were not working. In this PR, the EL1084 terminal was removed, and replaced with an EL1124 and EL9505. The limit switch outputs were linked to channels 3 and 4 in the EL1124. However, the limit switches are quite noisy, so Zach suggested using a counter to filter out the noise.

Motivation and Context

https://jira.slac.stanford.edu/browse/LCLSECSD-587

How Has This Been Tested?

This has been tested with the SDS X stage, and the limits are working as expected, despite the noise clearly visible on the digital IO.

Pre-merge checklist

klauer commented 1 year ago

For pre-commit info, see here: https://confluence.slac.stanford.edu/display/PCDS/TwinCAT+3+Git+Setup+and+Best+Practices#TwinCAT3GitSetupandBestPractices-Enableaccesstopre-commitandcondaingitbash