ENH: CRIX Motor PLC limits [ECS-3966]

jozamudi commented 1 year ago

Description

Add PLC limits to chemrix motors.

Motivation and Context

We want to be able to protect motion stages from running into each other. The 'plc limits' change depending on the current state of the system. We want the users to be able to know why the motor is not able to move, and change the 'plc limits' if needed.

https://jira.slac.stanford.edu/browse/ECS-3966

How Has This Been Tested?

We have checkout each limit in this ChemRIX EPS Table.

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

[x] Code works interactively
[x] Code contains descriptive comments
[x] Test suite passes locally
[x] Libraries are set to fixed versions and not Always Newest
[x] Code committed with pre-commit (alternatively pre-commit run --all-files)

ZLLentz commented 1 year ago

Adding https://jira.slac.stanford.edu/browse/ECS-3966 for reviewer context (this probably should have been in the PR description)

ZLLentz commented 8 months ago

@jozamudi I'm reviewing this now Is this still a WIP? If not, could you update the title tag to e.g. ENH? (enhancement)

ZLLentz commented 8 months ago

Does this need a re-review from me? Are there more changes you're planning to make?

jozamudi commented 8 months ago

I think this is ready. Just wanted to double check to get this PR approved.

ZLLentz commented 8 months ago

Ok I'll start reviewing now and resume in the afternoon if I need more time

ZLLentz commented 7 months ago

@jozamudi @jyotiphy would it be disruptive if I merged this now?

pcdshub / lcls-plc-crixs-motion