Closed jozamudi closed 7 months ago
Adding https://jira.slac.stanford.edu/browse/ECS-3966 for reviewer context (this probably should have been in the PR description)
@jozamudi I'm reviewing this now Is this still a WIP? If not, could you update the title tag to e.g. ENH? (enhancement)
Does this need a re-review from me? Are there more changes you're planning to make?
I think this is ready. Just wanted to double check to get this PR approved.
Ok I'll start reviewing now and resume in the afternoon if I need more time
@jozamudi @jyotiphy would it be disruptive if I merged this now?
Description
Add PLC limits to chemrix motors.
Motivation and Context
We want to be able to protect motion stages from running into each other. The 'plc limits' change depending on the current state of the system. We want the users to be able to know why the motor is not able to move, and change the 'plc limits' if needed.
https://jira.slac.stanford.edu/browse/ECS-3966
How Has This Been Tested?
We have checkout each limit in this ChemRIX EPS Table.
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newest
pre-commit
(alternativelypre-commit run --all-files
)