pcdshub / lcls-plc-kfe-gatt

LCLS II K line Gas Attenuator
Other
0 stars 4 forks source link

Changes for new LVDT, aperture 4, X-motion. #5

Closed mkestra closed 1 year ago

mkestra commented 1 year ago

This PR is to save changes that were made for the X-motion of Aperture 4 on AT1K0. the only changes here are to set the soft limits of the system for the newly calibrated LVDT and change the expected nominal point of the X-motion for PMPS. Latest commit was to run pre-commit and some significant formatting changes resulted in multiple files.

Description

Motivation and Context

The old LVDT on Aperture 4 was sticking so we replaced it with a new one and recalibrated.

How Has This Been Tested?

Verified with alignment that these parameters are sufficient when attempting to reach hard limits, soft limits, null point, and beam-center.

Where Has This Been Documented?

On a Jira ticket, https://jira.slac.stanford.edu/browse/LCLSECSD-1897

Screenshots (if appropriate):

Pre-merge checklist

mkestra commented 1 year ago

@ghalym this has now been pre-commit checked and should be ready for review. Please note a lot of, strictly formatting file changes from pre-commit.

mkestra commented 1 year ago

@ghalym I have just committed with a fresh run of pre-commit check and it now passes all checks. Kindly review and approve if appropriate? I need to start working on changes for the roughing pump configuration.