pcdshub / lcls-plc-kfe-gatt

LCLS II K line Gas Attenuator
Other
0 stars 3 forks source link

feat(PMF-140): reverted changes from Mike E PR #6 that correlated the PTM-140 0unit with the PMF-120 unit. The PTM-140 unit is now interlocked with its associated roughing pump PMF-140 #8

Closed joshc-slac closed 11 months ago

joshc-slac commented 11 months ago

Description

Reverted interlock change such that PTM-140 is interlocked via roughing pump PMF-140. The same was done for VVC-140.

https://github.com/pcdshub/lcls-plc-kfe-gatt/blob/05e5f9eddf00ce2afffb6fafd3af6d1ae5d45acb/plc-kfe-gatt/plc_kfe_gatt/POUs/PRG_GATT.TcPOU#L107

https://github.com/pcdshub/lcls-plc-kfe-gatt/blob/05e5f9eddf00ce2afffb6fafd3af6d1ae5d45acb/plc-kfe-gatt/plc_kfe_gatt/POUs/PRG_GATT.TcPOU#L137

https://github.com/pcdshub/lcls-plc-kfe-gatt/blob/05e5f9eddf00ce2afffb6fafd3af6d1ae5d45acb/plc-kfe-gatt/plc_kfe_gatt/POUs/PRG_GATT.TcPOU#L140

Motivation and Context

The roughing pump PMF-140 was reinstalled and reinterfced to turbo pump PTM-140. We must update the application logic such that PTM-140 is interlocked to PMF-140. This PR serves to revert PR #6 .

How Has This Been Tested?

Tested with Dan live. It works!

Where Has This Been Documented?

Screenshots (if appropriate):

We also updated the relevant UI screen hosted at location: reg/g/pcds/epics-dev/mghaly/screens/vacuumscreens/AT1K0-GAS.ui

image

image

^ tested with Dan. Beamline pressures still high but that is because the rest of the beam isn't vented.

Pre-merge checklist