search

pcdshub / lcls-plc-kfe-rix-motion

Beckhoff motion control for RIX beamline components in the FEE
https://pcdshub.github.io/lcls-plc-kfe-rix-motion
Other
1 stars 14 forks source link

Copying indexing change into IM4K2 PPM #73

Closed KaushikMalapati closed 1 month ago

KaushikMalapati commented 1 month ago

Description

Putting same indexing changes from https://github.com/pcdshub/lcls-twincat-common-components/pull/74 into the IM4K2 custom PPM function blocks

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

KaushikMalapati commented 1 month ago

Did someone turn off plc-kfe-rix-motion? I tried to activate configuration with only a version change to 3.8.1 for common-components but couldn't and then saw the plc was unpingable. I was able to login an hour ago and the plc seemed fine.

jyotiphy commented 1 month ago

why would someone turn off the PLC ? It's not pinging. Going to power-cylce it.

jyotiphy commented 1 month ago

Remote power-cycle isn't helping, which is very strange! :( Can you go to FEE rack room and power-cycle it manually and see the status LEDs ? @KaushikMalapati

KaushikMalapati commented 1 month ago

@jyotiphy @ZLLentz, can you think of what I did that would have caused the plc to go offline like this? It's currently running now with the same code that I tried earlier and the only thing I changed was pinning a new version of common components? (I initially had https://github.com/pcdshub/lcls-twincat-common-components/pull/74 as 0.0.0 but the code is the same) After activating configuration, I tried logging in but could not and then saw it was unpingable.

ZLLentz commented 1 month ago

I've had scattered rumors from various team members that the BSD PLCs go offline after the Nth activate config. I've not seen this myself nor been able to verify it.

The desired resolution for these sorts of problems will be to do a coordinated upgrade of the XAE and runtimes.

jyotiphy commented 1 month ago

I didn't know about this rumour 🤔 PLC came back alive after manual power-cycle.

jyotiphy commented 1 month ago

@ZLLentz can you please review, approve and merge this PR ?

ZLLentz commented 1 month ago

Let me know when it's time for me to help look at the associated delta-updates-not-working issue

jyotiphy commented 1 month ago

@ZLLentz I tested this again after deploying master branch and now it seems to be working! Not sure what was the issue yesterday but all seems good now. Its moving as expected for additional 7mm (both directions).

ZLLentz commented 1 month ago

Ok great! Good job everyone!