search

pcdshub / lcls-plc-las-bts

Laser Hall Beam Transport vacuum and shutter control
https://pcdshub.github.io/lcls-plc-las-bts/
Other
0 stars 4 forks source link

Vacuum min #2

Closed sfsyunus closed 3 years ago

sfsyunus commented 3 years ago

DEV: minimalist version of original code from Cosylab includes:

sfsyunus commented 3 years ago

@klauer halp where are my style checks and pre-commits failing? I linted pragmas successfully and removed trailing white spaces to my knowledge

klauer commented 3 years ago

Bunch o' leading tabs and related issues - that's what the style checks are after. At first glance, the text here looks unreadable but it is actually pretty helpful - https://travis-ci.com/github/pcdshub/lcls-plc-las-bts/jobs/477422161

Easiest way to get those fixed is to run pre-commit install; pre-commit run --all-files. Only caveat is it's not so easy to do that on the programming node just yet. Using psbuild it should be pretty straightforward though.

sfsyunus commented 3 years ago

Just found the docs on how to do this properly https://github.com/pcdshub/pre-commit-hooks/blob/master/README.md Sorry for premature cry for help :p

sfsyunus commented 3 years ago

Huzzah! Look at that, CI works when you set it up right, thanks @klauer