search

pcdshub / lcls-plc-mfx-be-lens-interlock

MFX Beryllium Lens Interlock PLC code (pairs with transfocate, ioc-mfx-tfs-lens)
https://pcdshub.github.io/lcls-plc-mfx-be-lens-interlock
Other
0 stars 2 forks source link

No lenses inserted -> infinite effective radius #9

Closed klauer closed 3 years ago

klauer commented 3 years ago

https://github.com/pcdshub/lcls-plc-mfx-be-lens-interlock/blob/7a797f71891badad1aa5e6aaf3af62ea5f0ae123/MFX_BE_LENS_INTERLOCK/POUs/F_EFF_RADIUS.TcPOU#L36-L38

This needs to be changed and diagrams updated.

klauer commented 3 years ago

However, I think the underlying checks are still accurate as it's not done on the basis of effective radius.

https://github.com/pcdshub/lcls-plc-mfx-be-lens-interlock/blob/7a797f71891badad1aa5e6aaf3af62ea5f0ae123/MFX_BE_LENS_INTERLOCK/POUs/p_MPSSup.TcPOU#L106-L118

klauer commented 3 years ago

So - there just doesn't need to be an additional plot region; that's OK. The "to infinity" region is captured in the table already. The "lens must be inserted" check is then just redundantly checking the same. I think I'll leave that in.

klauer commented 3 years ago

Closed by #10