pcdshub / lcls-twincat-general

A PLC code toolkit for LCLS TwinCAT PLC projects
https://pcdshub.github.io/lcls-twincat-general/
Other
16 stars 20 forks source link

Logger: consider buffering UDP packet sending #55

Open klauer opened 3 years ago

klauer commented 3 years ago

In lcls-plc-rixs-optics, @ZLLentz found that UDP packets were not always sent in a single cycle. (ref https://github.com/pcdshub/lcls-plc-rixs-optics/pull/75) It can reportedly be around 15 cycles.

I incorrectly had assumed this would be the case as well for logging via JSON-formatted UDP packets to logstash.

We should consider looking back into this - especially if we notice missing log messages following successful ones.