MNT: add user-customizable identifier "ledName" to FB_LED - Githubissues

pcdshub / lcls-twincat-general

A PLC code toolkit for LCLS TwinCAT PLC projects

https://pcdshub.github.io/lcls-twincat-general/

Other

16 stars 20 forks source link

MNT: add user-customizable identifier "ledName" to FB_LED #64

Closed Mbosum closed 2 years ago

Mbosum commented 2 years ago

Description

Added a String Pragma as a VAR_INPUT to the FB_LED.

Motivation and Context

I would like for there to be a description PV which will show up on the typhos screen, which will be user editable so users can label their LEDs.

How Has This Been Tested?

I have not been able to test this anywhere.

Where Has This Been Documented?

Pre-merge checklist

[x] Code works interactively
[x] Code contains descriptive comments
[ ] Test suite passes locally
[x] Libraries are set to Always Newest version (Library, *)
[ ] Committed with pre-commit or ran pre-commit run --all-files

Mbosum commented 2 years ago

@ZLLentz @klauer before I do all the pre-merge stuff, I just wanted to get your opinion on the String pragma.

klauer commented 2 years ago

It got lost in my queue, sorry @Mbosum!