MAINT: address static analysis messages, drop tmc

[ZLLentz]

Description

• Work through all rest of the static analysis build failures, following on from @sagatowski 's edits in #74

  • For some of these, I opted to delete the variable, e.g. when it was an internal VAR that never was used (or, is no longer used at present)
  • For others, I opted to ignore the warning, e.g. when it was a global that may be in use elsewhere or a property that can be set to and read from inside a plc project
  • I tried to be careful here but a second opinion is good
• Drop the tmc file, it isn't used in this context and generally just makes the diffs awful
• Update the .gitignore with our confluence link and refresh the list here

Motivation and Context

closes #75 Once merged, I get to see if the Jenkins pipeline runs all the way through (have not figured out PR config yet)

How Has This Been Tested?

The TcUnit tests build and pass now without modifying the project

Where Has This Been Documented?

N/A

Pre-merge checklist

• [x] Code works interactively
• [x] Code contains descriptive comments
• [x] Test suite passes locally
• [x] Libraries are set to Always Newest version (Library, *)
• [x] Committed with pre-commit or ran pre-commit run --all-files

[ZLLentz]

Oops!

(For the record, I deleted that file because there is an identical structure with the same name in Tc2_Ethercat)

[ZLLentz]

Ok, I feel good about this so I'm merging with just one review. We can revise these later if there was a good reason for any of the things I removed. I also just really want to see the jenkins pipeline run

[ZLLentz]

Huh, apparently the tmc was functional in this project as per #14, so I'll need to make a follow-up PR Locally the build still succeeded because, despite no longer being tracked, I hadn't deleted the tmc file

On CI the project doesn't build at all

[klauer]

Argghh, the event classes! You asked me specifically about the tmc and I had forgotten - sorry, @ZLLentz...

[ZLLentz]

The good news is that the CI pipeline catches these things

[ZLLentz]

I'm personally somewhat surprised that TwinCAT relies on what is nominally a built file for things like this, seems unstable

[sagatowski]

I'm copy-pasting what I wrote in #74: @ZLLentz & @klauer The reason I did a reverted commit is because the TMC-file is functional in your application. For some reason (don't know why, and didn't even know it was possible), the events are stored in your TMC-file. So this file needs to be there, otherwise you won't be able to build!

What I normally do for projects that use the Tc3_EventLogger is to make sure to store them in a separate file, which is possible to do in TwinCAT. You basically create a separate type in the type system where you store your events, and then you exclude ONLY THAT file in your gitignore but ignore all other TMC-files. Then you don't get the annoying behaviour of a changing TMC-file for every re-compilation.

So if you create a separate type system class (TMC): Then you get all your events here:

Then you can ignore ALL tmc-files except this one (this will remove the annoying tmc-file that changes everytime you do a compilation).

[ZLLentz]

That's a really helpful trick, I'll try it