pcdshub / lcls-twincat-motion

TwinCAT 3 Motion Control Utilities - PLC Motion Library for all PCDS Applications
https://pcdshub.github.io/lcls-twincat-motion
Other
35 stars 20 forks source link

Potential Race Condition in Arbiter Failure Edge Case #115

Open ZLLentz opened 3 years ago

ZLLentz commented 3 years ago

For the exit slits (SL1K2 target), we had a case where the arbiter wasn't sending us any data, but this was causing motion to fail entirely, instead of just timing out the arbiter request and doing the motion with a fast fault as is intended.

The motor is absolutely encoded, is configured for enable during motion, and works great other than the case where the arbiter isn't working, in which case it works... sometimes (???)