pcdshub / lcls-twincat-motion

TwinCAT 3 Motion Control Utilities - PLC Motion Library for all PCDS Applications
https://pcdshub.github.io/lcls-twincat-motion
Other
35 stars 20 forks source link

BUG: inset -> insert #159

Closed nrwslac closed 1 year ago

nrwslac commented 1 year ago

Description

DUT_MotionPneumaticActuator has a miss spelled pragma for the PV: bInsertDigitalOutput

typo, fix, insert 'r'

Motivation and Context

devices can't connect with this typo as the PV will be wrong.

https://github.com/pcdshub/pcdsdevices/pull/1088

How Has This Been Tested?

This typo was found while testing pneumatic.py

The pneumatic device can access the PV with the typo.

Where Has This Been Documented?

Pre-merge checklist

nrwslac commented 1 year ago

Are we supposed to load this lib with 4024? Should I test this by saving the library to a dev version and setting a plc-project to dev motion?

ZLLentz commented 1 year ago

Don't worry about the version header, it was probably a mistake to load it in 4024 in the first place. It won't cause any issues regardless.