MAINT/STY/DEP: renaming follow-ups from ND states - Githubissues

pcdshub / lcls-twincat-motion

TwinCAT 3 Motion Control Utilities - PLC Motion Library for all PCDS Applications

https://pcdshub.github.io/lcls-twincat-motion

Other

35 stars 20 forks source link

MAINT/STY/DEP: renaming follow-ups from ND states #183

Closed ZLLentz closed 1 year ago

ZLLentz commented 1 year ago

Description

Handle the renaming-related follow-up issues from #163 .

This includes:

a few internals
ENUM -> E
deprecation warning minimization
remove no longer used library sim axes

Motivation and Context

closes #167 closes #170 closes #171 closes #173 closes #174

How Has This Been Tested?

The unit tests still pass
check all objects just shows the deprecation warnings
I grepped for old names to see if I missed something

Where Has This Been Documented?

This will be included in the release notes

Pre-merge checklist

[x] Code works interactively
[x] Test suite passes locally
[x] Code contains descriptive comments
[x] Libraries are set to Always Newest version (Library, *)
[x] Committed with pre-commit or ran pre-commit run --all-files

ZLLentz commented 1 year ago

I probably only need 1 sanity review on this one- no functional changes, just follow-ups from the previous large states PR comments + closer adherence to our twincat style guide