pcdshub / lcls-twincat-motion

TwinCAT 3 Motion Control Utilities - PLC Motion Library for all PCDS Applications
https://pcdshub.github.io/lcls-twincat-motion
Other
35 stars 19 forks source link

FB_MotionBPTM does not properly allow for fault resetting #202

Closed ZLLentz closed 1 year ago

ZLLentz commented 1 year ago

Current Behavior

Sets the reset bits to TRUE under certain cases, but never drops them to FALSE in any cases Since the fast fault block is looking for a rising edge reset, this means that these FBs can only be reset exactly once

Expected Behavior

We should be able to reset these fast faults many times as needed

Suggested Solution

Go through all the fast fault handling in this repo and make sure that we don't hold the reset flag high