pcdshub / lcls-twincat-motion

TwinCAT 3 Motion Control Utilities - PLC Motion Library for all PCDS Applications
https://pcdshub.github.io/lcls-twincat-motion
Other
35 stars 20 forks source link

Add FB_BasicStats for encoders by default (report stdev/average/etc) [ECS-1534] #204

Open klauer opened 1 year ago

klauer commented 1 year ago

Expected Behavior

Each encoded stage should have statistics about its current position recorded at all times and exposed to EPICS. This diagnostic information could be important for diagnosing issues with any stage - and we might not know it until we need it.

Context / environment

The issue calls for statistics on critical axes, but I would argue that we should calculate them for all:

https://jira.slac.stanford.edu/browse/ECS-1534

... [A] lesson learned here is to make sure all critical axes like those for mirrors come equipped with the statistics FB blocks so we are always measuring the noise RMS. Our engineering specifications only call for one test, but it's a sad day when noise suddenly appears and we have no hope to correlate it with some configuration change.

ZLLentz commented 1 year ago

I agree.

We should decide on the default settings for this. Essentially we can pick between: