BUG: reverse the in/out order in the in/out example fbs to match their enum - Githubissues

pcdshub / lcls-twincat-motion

TwinCAT 3 Motion Control Utilities - PLC Motion Library for all PCDS Applications

https://pcdshub.github.io/lcls-twincat-motion

Other

35 stars 19 forks source link

BUG: reverse the in/out order in the in/out example fbs to match their enum #209

Closed ZLLentz closed 7 months ago

ZLLentz commented 8 months ago

Description

Reverse IN and OUT indices for the example state FBs to match the enum, because if the order is wrong then IN sends us to OUT and vice versa. See https://github.com/pcdshub/lcls-twincat-motion/blob/master/lcls-twincat-motion/Library/DUTs/E_EpicsInOut.TcDUT

Motivation and Context

closes #208

How Has This Been Tested?

Fixes the remaining issue in https://github.com/pcdshub/lcls-plc-kfe-rix-motion/pull/61

Where Has This Been Documented?

only here

Pre-merge checklist

[x] Code works interactively
[ ] Test suite passes locally
[ ] Code contains descriptive comments
[x] Libraries are set to Always Newest version (Library, *)
[x] Committed with pre-commit or ran pre-commit run --all-files

ZLLentz commented 7 months ago

The unit tests pass, provided you don't run them on the BSD PLCs... this is new to me and something I'll have to resolve as part of the TwinCAT CI project.

I'd appreciate if I could get 1 sanity check on this. The diff is pretty straightforward and doesn't require a full understanding of the library.