pcdshub / lcls-twincat-motion

TwinCAT 3 Motion Control Utilities - PLC Motion Library for all PCDS Applications
https://pcdshub.github.io/lcls-twincat-motion
Other
35 stars 20 forks source link

It is possible for the json state params to fail to load at startup #212

Open ZLLentz opened 9 months ago

ZLLentz commented 9 months ago

Current Behavior

In some rare race condition, loading the json file using lcls-twincat-pmps may fail.

You can recover this pretty easily using the pmpdb client tool:

(pcds-5.8.1)zlentz@rix-console:~$ pmpsdb reload plc-kfe-rix-motion
INFO: Last file reloaded at: Wed Dec 31 16:00:00 1969
INFO: Refreshing...
INFO: This file reloaded at: Fri Feb  9 14:33:06 2024

See https://github.com/pcdshub/lcls-twincat-motion/pull/211#issuecomment-1936692938

Expected Behavior

It should work every time, maybe it should automatically retry a couple times if it fails?

Context / environment

Happened once in prod

Steps to Reproduce (for bugs)

Unknown

Suggested Solution

Retry a few times?