pcdshub / lcls-twincat-motion

TwinCAT 3 Motion Control Utilities - PLC Motion Library for all PCDS Applications
https://pcdshub.github.io/lcls-twincat-motion
Other
35 stars 19 forks source link

Update FB_MotionPneumaticActuator to include a flow meter #220

Closed nrwslac closed 1 month ago

nrwslac commented 1 month ago

Description

-Adds FB_FDQ_FlowMeter to FB_MotionPneumaticActuator

Motivation and Context

ST4K4 in TMO gets a flow meter.

How Has This Been Tested?

Running on TMO motion, on local copy of common components.

Where Has This Been Documented?

Pre-merge checklist

ZLLentz commented 1 month ago

You should note that this FB is for general pneumatic motion, not just for the TMO stopper, though it seems like this has only been used for stoppers in practice: https://github.com/search?q=org%3Apcdshub%20FB_MotionPneumaticActuator&type=code Do all the cases in the above search also have flow meters added? (ST3K2, ST5K4). Are there any consequences to having the extra PVs, code, and link points available for instances without flow meters?

nrwslac commented 1 month ago

FB_MotionPneumaticActuator

I think this is a good point. Not all PneumaticActuators will use an FDQ Flow meter. I am going to close this and add an FDQ flow meter to ST4K4's program.

nrwslac commented 1 month ago

On review, not all actuators utilizing FB_MotionPneumaticActuator will use an FDQ flow meter.