search

pcdshub / lcls-twincat-optics

TwinCAT 3 Motion Control for LCLS Optics
https://pcdshub.github.io/lcls-twincat-optics/
Other
0 stars 6 forks source link

ENH: release and install library 0.4.0 #15

Closed nrwslac closed 2 years ago

nrwslac commented 2 years ago

Need review to push library release.

klauer commented 2 years ago

I think the library release process might be a bit different than what you're doing here, and should be routed through tc-release like we do normal PLC projects: https://confluence.slac.stanford.edu/display/PCDS/How+to+Release+and+Install+Vacuum+PLC+Library

nrwslac commented 2 years ago

reviewing link.

klauer commented 2 years ago

I might not have actually gone through the process myself, I forget... 😁
@ZLLentz, does the process you follow match the link above from Jing?

nrwslac commented 2 years ago

I'll close this pull request. Follow procedure outline in link.

nrwslac commented 2 years ago

used tc-release and vacuum library how to release notes instead of this.

ZLLentz commented 2 years ago

Confirming that you did the correct procedure as far as I can tell For bonus points you can come back later and include release notes at https://github.com/pcdshub/lcls-twincat-optics/releases/tag/v0.4.1 so that we know what was added/fixed in that version