Make 4024.12 compliant - Githubissues

pcdshub / lcls-twincat-optics

TwinCAT 3 Motion Control for LCLS Optics

https://pcdshub.github.io/lcls-twincat-optics/

Other

0 stars 6 forks source link

Make 4024.12 compliant #19

Closed nrwslac closed 1 year ago

nrwslac commented 1 year ago

Description

Changed offending STRING vars in FB_PI_E621_SerialTransaction and FB_PI_E621_SerialDriver to T_MaxString
Installed as library version 0.6.1
Built with twincat version 4024.12.
pre-commit run for the first time here.
Motivation and Context

Tried to build lcls-plc-xrt-optics with 4024.12 and found STRING vars incompatible with F_STRING built in FB.

How Has This Been Tested?

lcls-plc-xrt-optics running this version.

Where Has This Been Documented?

Pre-merge checklist

[ ] Code works interactively
[ ] Code contains descriptive comments
[ ] Test suite passes locally
[ ] Libraries are set to Always Newest version (Library, *)
[ ] Committed with pre-commit or ran pre-commit run --all-files

ZLLentz commented 1 year ago

Nick is on leave right now, I'm going to push small packaging changes here and do tc-release stuff. This is coming up because Tong is trying to work on tmo optics and got confused