Separate Beam Parameters Not Loaded FFO - Githubissues

pcdshub / lcls-twincat-optics

TwinCAT 3 Motion Control for LCLS Optics

https://pcdshub.github.io/lcls-twincat-optics/

Other

0 stars 6 forks source link

Separate Beam Parameters Not Loaded FFO #20

Closed nrwslac closed 7 months ago

nrwslac commented 8 months ago

Description

Pinned build version to 4024.35
Made a new Fast Fault for Beam parameters not loaded.
changes to lcls-twincat-optics/lcls_twincat_optics_plc/POUs/Helpers/FB_MirrorTwoCoatingProtection.TcPOU the rest are pre commit changes.
updated FB_MirrorTwoCoatingProtection to be backward compatible. That is, pmps states need not be implemented in JSON database file for this function block to work.
add bUsePmpsDb flag.

Motivation and Context

Fast Fault descriptions for coating faults were showing up as beam parameters not loaded when in fact they were. Fast Fault descriptions only run once during set up.
How Has This Been Tested?
running on lcls-plc-tmo-optics

Where Has This Been Documented?

Pre-merge checklist

[ ] Code works interactively
[ ] Code contains descriptive comments
[ ] Test suite passes locally
[ ] Libraries are set to Always Newest version (Library, *)
[ ] Committed with pre-commit or ran pre-commit run --all-files

nrwslac commented 8 months ago

Looks good to me, positive change that addresses some older feedback Thank you for updating the PMPS type codes page

Looking at the upcoming changes to lfe-optics, I decided to also make this backward compatible, which probably should have been done to begin with.

nrwslac commented 8 months ago

I think we can let this hang for a bit. I'll test it during PAMM and request a new review @ZLLentz

nrwslac commented 7 months ago

This is ready for review. I ran it on lcls-plc-tmo-optics and checked the kfe pmps diagnostics; it looked correct.