pcdshub / lcls-twincat-pmps

Photon Machine Protection System (PMPS) TwinCAT library for LCLS-II
https://pcdshub.github.io/lcls-twincat-pmps
Other
2 stars 7 forks source link

DEV: Added ST4K4 to the veto devices. #108

Closed ghalym closed 2 years ago

ghalym commented 2 years ago

Description

Added ST4K4 In and Out status to Veto device

Motivation and Context

TMO wants to Veto faults and arbitration for devices downstream of the ST4K4 photon terminator when it is in.

How Has This Been Tested?

Not yet!

Where Has This Been Documented?

In the Code.

Pre-merge checklist

ghalym commented 2 years ago

Does this need a corresponding update in another project to report the stopper status?

The diff looks good to me. I also double-checked that MAX_VETO_DEVICES is greater than our total count here (it is, 16>8)

Yes, making changes on the K arbiter, there is a WIP pull request on the kfe-arbiter. Still need to add the PMPS_PRE inputs to read the ST4K4.

ZLLentz commented 2 years ago

Good call on consistent stopper interfacing