DEV: Adding sDev name to address issue#82

pcdshub / lcls-twincat-pmps

Photon Machine Protection System (PMPS) TwinCAT library for LCLS-II

https://pcdshub.github.io/lcls-twincat-pmps

Other

2 stars 7 forks source link

DEV: Adding sDev name to address issue#82 #91

Closed ghalym closed 3 years ago

ghalym commented 3 years ago

Necessary function have been modified. This has been tested on a sim vac project. It didn't break older versions of the vacuum lib That doesn't include sDevname. Need new updated Vacuum and Motions libs to include sDeviceName when calling BPTM.

CaptureTest

ZLLentz commented 3 years ago

Docs build fails on /home/travis/build/pcdshub/lcls-twincat-pmps/Solution Items missing, so I suspect there is some trickery where one of the project files references this non-existent directory. Unrelated to this PR.

ZLLentz commented 3 years ago

I've added the corresponding update the pmps-ui as a PR. See https://github.com/pcdshub/pmps-ui/pull/43

ghalym commented 3 years ago

@slacAWallace any comments?