search

pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

MNT: Compat with Latest Happi #100

Closed ZLLentz closed 4 years ago

ZLLentz commented 4 years ago

Description

Happi enforces that name must be a valid Python identifier now. I did a sloppy find/replace so that the tests pass again.

ZLLentz commented 4 years ago

I think there is something funky going on with loading devices with invalid fields, while loading devices with missing fields seems to be okay...

hhslepicka commented 4 years ago

@ZLLentz I think as long as you don't try to set the fields with an invalid value it is okay. save would get the missing required fields but at instantiation it will barf if the value does not meet the required format.

ZLLentz commented 4 years ago

@hhslepicka then maybe the name field is special (because it is doubling as the id_ field?). Loading a database with an invalid name does not work.

ZLLentz commented 4 years ago

Unless some local saving is happening in this testing suite