Closed ZLLentz closed 4 years ago
I will let this sit here until we finish the happi refactors
New happi is tagged; need to wait for it to get to the conda channels for tests to pass.
Cycled CI for new happi release 🤞
It failed when I cycled it earlier. Never lucky! But it isn't actually picking up the right release. So there's something easy to try tomorrow.
😕 weird... build phase:
happi: 1.5.0-py36_0 pcds-tag
Test phase:
happi-1.1.1 | py36_0 69 KB pcds-tag
Style check is failing the tests now.
$ flake8 lightpath
lightpath/controller.py:14:1: F401 'happi.loader.from_container' imported but unused
The command "flake8 lightpath" exited with 1.
Merging #101 into master will decrease coverage by
0.02%
. The diff coverage is71.42%
.
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 89.16% 89.14% -0.03%
==========================================
Files 7 7
Lines 526 525 -1
==========================================
- Hits 469 468 -1
Misses 57 57
Impacted Files | Coverage Δ | |
---|---|---|
lightpath/controller.py | 81.66% <71.42%> (-0.31%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 34e434b...7e28952. Read the comment docs.
Description
We're generalizing and cleaning up
happi
, so some API is changing. This adjustslightpath
for it.How Has This Been Tested?
Tested locally with dev builds until a release
attn @klauer @hhslepicka