search

pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

REF: lightpath script -> entry point #103

Closed klauer closed 4 years ago

klauer commented 4 years ago

Also pep8 and isort fixes

Untested locally

ZLLentz commented 4 years ago

I stopped commenting on all of them, but isort seems to get it very wrong because it cannot properly differentiate between a third-party library and a local library.

ZLLentz commented 4 years ago

Code looks good though

codecov-io commented 4 years ago

Codecov Report

Merging #103 into master will decrease coverage by 5.2%. The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   89.16%   83.95%   -5.21%     
==========================================
  Files           7        8       +1     
  Lines         526      561      +35     
==========================================
+ Hits          469      471       +2     
- Misses         57       90      +33
Impacted Files Coverage Δ
lightpath/launcher.py 0% <0%> (ø)
lightpath/ui/widgets.py 93.33% <100%> (+0.06%) :arrow_up:
lightpath/ui/gui.py 93.4% <100%> (+0.03%) :arrow_up:
lightpath/ui/__init__.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 34e434b...770c64b. Read the comment docs.