pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

Revisit Branching #107

Closed ZLLentz closed 2 years ago

ZLLentz commented 4 years ago

Expected Behavior

Branching should be simple and consistent to configure, determined before runtime, and be able to handle cases of multiple inputs and multiple outputs.

Current Behavior

Branching is configured differently on different devices and cannot handle multiple input paths. In general, branching information is retrieved from the device at runtime through the attributes: .branches for a list of possible output beamlines .destination for the current output beamlines

Possible Solution

Another off-the-cuff API suggestion (coupled with #106):

Context

LCLS2 will have two sources that can go to either line. LCLS1's XCS LODCM already has two inputs.

klauer commented 4 years ago

Also sounds good - though going toward named inputs/outputs as in #106 would be my preference, if possible.

ZLLentz commented 4 years ago

I think named inputs and outputs is a clear winner here :+1:

tangkong commented 2 years ago

Closed by #133 , and the eventual https://github.com/pcdshub/pcdsdevices/pull/1028