search

pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

Make device handling more robust #139

Closed tangkong closed 2 years ago

tangkong commented 2 years ago

Expected Behavior

  1. Figure out how to best classify devices as "upstream" and apply this to lightpath.gui.LightApp.filter

  2. Properly handle devices that fail to instantiate. (lightpath.controller.LightController.make_graph)

Current Behavior

Currently the gui will just take the whole active path, need to figure out how to best handle upstream and downstream devices

Possible Solution

1: added logic. might be sufficient on the gui side of things? 2: Possibly make a dummy device that spoofs the missing device? Mimic the container's input / output devices?

Context

Left behind from #133

Your Environment

pcds-5.4.1 + #133

tangkong commented 2 years ago

Part 1 addressed in #142 Part 2 may be addressed in #145

tangkong commented 2 years ago

Closed by the aforementioned PRs 🎉