GUI: Fix device type filters

pcdshub / lightpath

LCLS Lightpath Module

https://pcdshub.github.io/lightpath

Other

4 stars 9 forks source link

GUI: Fix device type filters #144

Closed tangkong closed 1 year ago

tangkong commented 1 year ago

Expected Behavior

Device type filter checkboxes should properly hide/show devices

Current Behavior

Check boxes currently don't work

Possible Solution

The checkboxes filter on happi container, but should probably filter on device_class. It might be worth populating these more dynamically? Currently we only provide the option to filter a fixed set of device types Some devices are subclasses of others, so maybe we group those together somehow?

Your Environment

pcds-5.4.1

tangkong commented 1 year ago

Basic mechanisms for this will be introduced in #150, but that PR is cluttered already and this may deserve a separate effort to:

incorporate logic for gathering device types and grouping them
possibly clean up device definitions in pcdsdevices to make inheritance more sensible
possibly investigate a weird double-free error that pops up randomly but we have no clue how to reproduce? It appeared near interactions with the device_types combo boxes.