pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

DOC: release notes for v1.0.1 #168

Closed tangkong closed 1 year ago

tangkong commented 1 year ago

Description

Quick bugfix tag

Motivation and Context

get a bugfix out before the new env?

How Has This Been Tested?

make html ran without issue

Where Has This Been Documented?

This is documentation yay

ZLLentz commented 1 year ago

What happened to the travis build though? It didn't even get to the running-our-code part. I'll restart that job.

0.19s$ pytest "${PYTEST_ARGS[@]}"
Traceback (most recent call last):
  File "/home/travis/micromamba/envs/testenv/bin/pytest", line 11, in <module>
    sys.exit(console_main())
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/_pytest/config/__init__.py", line 190, in console_main
    code = main()
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/_pytest/config/__init__.py", line 148, in main
    config = _prepareconfig(args, plugins)
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/_pytest/config/__init__.py", line 329, in _prepareconfig
    config = pluginmanager.hook.pytest_cmdline_parse(
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/pluggy/_hooks.py", line 265, in __call__
    return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/pluggy/_manager.py", line 80, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/pluggy/_callers.py", line 55, in _multicall
    gen.send(outcome)
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/_pytest/helpconfig.py", line 103, in pytest_cmdline_parse
    config: Config = outcome.get_result()
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/pluggy/_result.py", line 60, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/pluggy/_callers.py", line 39, in _multicall
    res = hook_impl.function(*args)
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1058, in pytest_cmdline_parse
    self.parse(args)
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1346, in parse
    self._preparse(args, addopts=addopts)
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1229, in _preparse
    self.pluginmanager.load_setuptools_entrypoints("pytest11")
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/pluggy/_manager.py", line 287, in load_setuptools_entrypoints
    plugin = ep.load()
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/importlib/metadata.py", line 86, in load
    module = import_module(match.group('module'))
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/_pytest/assertion/rewrite.py", line 168, in exec_module
    exec(co, module.__dict__)
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/pytestqt/plugin.py", line 9, in <module>
    from pytestqt.logging import QtLoggingPlugin, _QtMessageCapture
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/_pytest/assertion/rewrite.py", line 168, in exec_module
    exec(co, module.__dict__)
  File "/home/travis/micromamba/envs/testenv/lib/python3.9/site-packages/pytestqt/logging.py", line 5, in <module>
    from py._code.code import TerminalRepr, ReprFileLocation
ModuleNotFoundError: No module named 'py._code'; 'py' is not a package
The command "pytest "${PYTEST_ARGS[@]}"" exited with 1.
ZLLentz commented 1 year ago

The tests passed on the previous PR so this must be a weird CI issue- maybe some random dependency or test dependency updated? I suspect we can still run pytest interactively without issues.

ZLLentz commented 1 year ago

pytest itself got an update on conda-forge like 2 hours ago, it could be related

ZLLentz commented 1 year ago

Possibly a packaging issue related to:

pytest no longer depends on the py library. pytest provides a vendored copy of py.error and py.path modules but will use the py library if it is installed. If you need other py.* modules, continue to install the deprecated py library separately, otherwise it can usually be removed as a dependency.

ZLLentz commented 1 year ago

Ok, that's all it is- pytest-qt needs a new version uploaded for compat with pytest v7.2.0. All the work is already done and we're just at a bad timing in the conda-forge machinery.

tangkong commented 1 year ago

Ok with a pytest pin, these tests pass. I'm going to merge and tag