pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

BLD: Consider removing `pcdsdevices` dependency #172

Closed tangkong closed 1 year ago

tangkong commented 1 year ago

Current Behavior

lightpath currently depends on pcdsdevices , which in turn relies on lightpath. This is a dreaded circular dependency, and should be removed.

Possible Solution

A cursory look reveals that pcdsdevices is only used for AggregateSignal, to create mock devices. We should probably just vendor that signal instead

Context

After causing Ken hours of grief, we finally thought to suspect the recipe.

Your Environment

pcds-5.6.0, and Ken's GHA / docker container