search

pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

MNT: split XPP into XPP-PINK and XPP-MONO #176

Closed tangkong closed 1 year ago

tangkong commented 1 year ago

Description

Splits XPP's single entry in the default config into two: XPP_MONO and XPP_PINK.
Fixes the test suite accordingly Fixes a small bug on the way that didn't re-filter the visible devices after changing a path.

Motivation and Context

All caps because of some string.upper() stuff we do in the GUI.

Previously XPP would have two possible beampaths splitting at the xpp lodcm. One going on the L0 branch and one on the L2 branch. While before we were letting lightpath choose which branch is active (by whichever branch has the sees beam at the highest z), it became clear that XPP would want to see the status of either line independently.

The test_path/test_callback test failed again, but passed after a re-run. I tried adding in a sleep clause to possibly let it process, but the failures are intermittent enough that it'll be tough to nail down. This is not the only test that might benefit from this kind of pause, as many other tests invoke similar code paths.

Perhaps we just resign ourselves to re-running test jobs. At least GHA shows past results from re-run jobs

How Has This Been Tested?

Interactively.

Where Has This Been Documented?

This PR, and JIRA

ZLLentz commented 1 year ago

The 3.11 conda build failure is probably due to the pyqt pin The other 3.11 failure may be harder to track down