pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

RIX paths don't match reality #183

Open ZLLentz opened 1 year ago

ZLLentz commented 1 year ago

Expected Behavior

Current Behavior

Possible Solution

Discuss and collaborate with RIX to figure out the correct/best way to show these

Context

This broke the lightpath device loading in rix hutch python because hutch is set to "rix" and we only have lightpath configs for "crix" and "qrix"

Your Environment

pcds-5.7.1

jyotiphy commented 1 year ago

@ZLLentz I did notice that earlier but didn't get chance to talk to @tangkong yet. I think we can combine lightpath to just RIX as the beampath is very much similar for both Endstations. We can have more discussion on this and see what fits better in this case.

tangkong commented 1 year ago

The path toward combining crix and qrix seems to be simple... I think.

Currently the lightpath map looks like this, an there are devices in both the K1 and K2 lines after the branching point (mr1k2_switch) image

To combine these lines we'd need to:

tangkong commented 1 year ago

the 4 devices on the K1 line after mr1k2_switch all seem to be around z=790, are they in use still?

n [18]: [(res.metadata['name'], res.metadata['z'], res.metadata['active']) for res in K1_res if res.metadata['z'] > 74
    ...: 2.922]
Out[18]:
[('crixs_rcc_vrc_1', 790.00999, True),
 ('crixs_rcc_vrc_2', 790.00998, True),
 ('crixs_rcc_vrc_3', 790.00997, True),
 ('crixs_rcc_vrc_4', 790.00996, True)]
ZLLentz commented 1 year ago

I think those are all on the K2 line in reality, according to the location of crix on https://confluence.slac.stanford.edu/display/L2SI/RIX