pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

BLD: separate lightpath and lightpath[gui] subpackages #190

Closed tangkong closed 2 weeks ago

tangkong commented 2 weeks ago

Description

Separates lightpath base and gui-related dependencies

Motivation and Context

Lightpath keeps dragging qt dependencies along with it

How Has This Been Tested?

pip installs locally. Conda eventually, but let's see if CI takes

Where Has This Been Documented?

This PR

tangkong commented 2 weeks ago

After quite a bit of squinting at conda build logs, I've arrived at a point where the conda build step succeeds, but the test environment gets clobbered/lost and cannot be used for the rest of the test suite. This is despite the environment artifact being created and uploaded sensibly

The changes to the pip-side of things have worked from the onset, and I think are good moving forward. A nearly identical recipe works on the lightpath-feedstock and passes their build tests, so I think we'll revert this repo's recipe to the combined recipe and only split up the feedstock recipe.

tangkong commented 2 weeks ago

adding --no-deps managed to remove the clobber warnings I think. There definitely was some double installations going on, I think what happens is that without --no-deps, the pip install installs all the package dependencies, then conda tries to follow the recipe and install them again.

We still lose the test_env folder though 😢

ZLLentz commented 2 weeks ago

The remaining py311 failures come from pinning pytest<7.2.0, before this version it wasn't marked as noarch so the allowed versions are very pinned down

tangkong commented 2 weeks ago

Ah we unpinned this a while ago. This was from an era where pytest-qt wasn't compatible

ZLLentz commented 2 weeks ago

It's all GREEEN