pcdshub / lightpath

LCLS Lightpath Module

https://pcdshub.github.io/lightpath

Other

4 stars 9 forks source link

ENH: Show happi containers in UI #20

Closed teddyrendahl closed 6 years ago

teddyrendahl commented 6 years ago

Closes #19 and also part of #16

Features

Before, if a device failed to load, we would drop it from the lightpath. This could have some poor side affects if an IOC is down and the associated device is left in the beam the operators still need to be able to use the path as map. The GUI can now be passed a list of happi containers that will be considered "disconnected". The implementation was a bit of a pain as I had to find where each device fits along the path since I can't re-use the function internal to LightController
The entire thing is now in a GridLayout. This will make it cleaner looking on different fonts and systems

Questions

Not in love with the blacked out lightpath for disconnected devices?
After the switch to a GridLayout I lost the ability to put the entire row in a single frame. Is it worth the time to light the entire frame in case of an MPS fault, or am I just picking at scabs?

codecov-io commented 6 years ago

Codecov Report

Merging #20 into master will decrease coverage by 1.15%. The diff coverage is 85.85%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   87.83%   86.68%   -1.16%     
==========================================
  Files           7        7              
  Lines         337      398      +61     
==========================================
+ Hits          296      345      +49     
- Misses         41       53      +12

Impacted Files	Coverage Δ
lightpath/path.py	`88.23% <100%> (-0.18%)`	:arrow_down:
lightpath/tests/__init__.py	`100% <100%> (ø)`	:arrow_up:
lightpath/ui/gui.py	`83.62% <76.47%> (-2.46%)`	:arrow_down:
lightpath/ui/widgets.py	`85.39% <95.65%> (-0.33%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 563378a...d66bfaf. Read the comment docs.

hhslepicka commented 6 years ago

What about purple for the disconnected devices? For alarms we are using white... but I'm not sure how it will look like. Would you mind making the UI so it does not require horizontal scrolling? The UI looks great to me! I really liked it.

teddyrendahl commented 6 years ago

@ZLLentz Yeah there is a way, but involves putting a frame around each cell and then specifically lighting up each side of the border. I can do it, just felt like it could be in a later PR. I'll add it to #16

@hhslepicka The disconnected is purple? Or do you want all the text purple? Also I'm having trouble getting the UI to expand at all in horizontal. Maybe you and I can take a look.

hhslepicka commented 6 years ago

@teddyrendahl The rectangle on the side of FEE Valve 3 can be purple if you want to match the label Disconnected PS: I'm really bad at color names and colors in general! 😞 Sure... let's take a look at this expanding issue.