search

pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

Fix travis #2 #38

Closed hhslepicka closed 6 years ago

hhslepicka commented 6 years ago

Fix Travis bug with Numpy from pip missing openblas library.

Description

The previous fix ( PR #37 ) did not fixed the issue. Looking at the TravisCI log I noticed that we had duplicated packages showing as conda installed and pip installed. Since all the dependencies (except QDarkStyleSheet which is optional) are set at conda create there is no need to call pip install -r requirements.txt at travis.yml.

Motivation and Context

This change is required so we can properly build Lightpath.

How Has This Been Tested?

At my environment & Travis (https://travis-ci.org/hhslepicka/lightpath/jobs/302070533).

Where Has This Been Documented?

In here.

codecov-io commented 6 years ago

Codecov Report

Merging #38 into master will increase coverage by 0.21%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   91.59%   91.81%   +0.21%     
==========================================
  Files           7        7              
  Lines         464      464              
==========================================
+ Hits          425      426       +1     
+ Misses         39       38       -1
Impacted Files Coverage Δ
lightpath/ui/gui.py 90.17% <0%> (+0.57%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0863be...9f01104. Read the comment docs.