Description

API

Instead of passing already configured devices into LightController you pass a happi.Client. The LightController is then responsible for selecting the correct devices and instantiating them.
LightApp takes a LightController object instead of a list of devices.

Enhancements

The LightController has an optional endstations keyword that will only load a list of hutches beampaths.

Maintenance

Prior to this PR, the LightController used a tangled web of code to stitch together beamlines based on the device it found. This is now hard coded in lightpath/config. There is a beamlines dictionary where each endstation is a key with a nested dictionary describing the complete path. You can just leave the smaller dictionary blank indicating you want to include the entire beamline, or you can optionally specify a start and/or end to select part of a section of beamline.

Fixes

Fixes a bug where we looked for branches property on the md sub-attribute rather than the device. The tests were mistakenly updated in a prior PR as well. These have both been rectified.

Motivation and Context

Closes #32 Closes #47

Do you think this closes #18? This new configuration will create two paths PBT and XCS. This greatly improves the situation as the PBT path will include devices in the XCS hutch itself.

How Has This Been Tested?

Minimal changes to tests. Updated to new API.

Where Has This Been Documented?

Updated docstrings

Codecov Report

Merging #51 into master will decrease coverage by 0.01%. The diff coverage is 88.63%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage    87.3%   87.28%   -0.02%     
==========================================
  Files           6        7       +1     
  Lines         386      409      +23     
==========================================
+ Hits          337      357      +20     
- Misses         49       52       +3

Impacted Files	Coverage Δ
lightpath/path.py	`83.21% <100%> (-0.7%)`	:arrow_down:
lightpath/ui/gui.py	`92.43% <100%> (ø)`	:arrow_up:
lightpath/config.py	`100% <100%> (ø)`
lightpath/controller.py	`81.66% <86.84%> (+4.16%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71de692...45e7ffa. Read the comment docs.

pcdshub / lightpath

API: Controller #51