search

pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

Show position in screen instead of inserted/removed #58

Closed ZLLentz closed 6 years ago

ZLLentz commented 6 years ago

It has been requested multiple times to have the attenuator show it's attenuation value, the slits show their openness, etc. in the gui.

My suggestion is to use the position attribute to display the text, and use inserted and removed to color it. This covers all the devices where we care about some number more than we care about inserted or removed, and gives more information for things like the pulse picker which can be OPEN, CLOSED, OUT

teddyrendahl commented 6 years ago

I agree. The lightpath was written before we had standardized the StatePositioner class. This greatly helps make the UI more specific.

teddyrendahl commented 6 years ago

@ZLLentz thoughts on using the hints instead of position. Benefits are I can subscribe directly to the hinted signals and use PyDM widgets.

ZLLentz commented 6 years ago

Seems reasonable. I think we floated this idea before there were "hinted" signals to subscribe to. The new interface makes this slightly nicer. We're also dropping the assumption of a position attribute.