search

pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

MAINT: DeviceState in UI #69

Closed teddyrendahl closed 6 years ago

teddyrendahl commented 6 years ago

Description

Since the last release of lightpath we now summarize the state of every device in a convenient enum DeviceState. This change had not made its way up to the UI. Previously we created a custom Enum here by checking inserted and removed, this is now removed in favor of find_device_state.

CI Changes

We were also using a bunch of varying Conda channels we no longer depend on. Updated both Travis and the README to show the simpler install. Also added flake8

Motivation and Context

Closes #65

How Has This Been Tested?

Strengthened existing test

Screenshots

screen shot 2018-07-09 at 6 03 16 pm
codecov-io commented 6 years ago

Codecov Report

Merging #69 into master will increase coverage by 0.73%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   87.73%   88.47%   +0.73%     
==========================================
  Files           7        7              
  Lines         432      425       -7     
==========================================
- Hits          379      376       -3     
+ Misses         53       49       -4
Impacted Files Coverage Δ
lightpath/ui/widgets.py 94.2% <100%> (+4.72%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e126193...6427e85. Read the comment docs.

ZLLentz commented 6 years ago

Does this also close #58 ?

teddyrendahl commented 6 years ago

Not quite. This shows the DeviceState, we want to see the position i.e my attenuation. This is coming in the next PR that will use a combination of Typhon and device hints.