Closed teddyrendahl closed 6 years ago
Nice design... quick question... is there a case where the name on top is different than the name under it? E.g. FEE Valve 1 and (Fee Valve 1)
Merging #72 into master will increase coverage by
0.35%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 87.36% 87.72% +0.35%
==========================================
Files 7 7
Lines 380 391 +11
==========================================
+ Hits 332 343 +11
Misses 48 48
Impacted Files | Coverage Δ | |
---|---|---|
lightpath/ui/widgets.py | 87.71% <100%> (+1.44%) |
:arrow_up: |
lightpath/ui/gui.py | 94.79% <100%> (+0.28%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d80f70d...75ea9e9. Read the comment docs.
@hhslepicka Should have shared what the version on live devices looks like. That will be the PV prefix for real devices. I don't put it there in the simulation so I don't get them confused 😉
Awesome! Thank you for the reply @teddyrendahl ! ;)
Description
Part of the transformation to making the UI look more like the old system. We now create a mock "drawing" of the beamline that lights up according to the device state and whether the beam is being transmitted or not.
Screenshots (if appropriate):