search

pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

Better handle subscriptions #75

Closed teddyrendahl closed 6 years ago

teddyrendahl commented 6 years ago

Expected Behavior

Not all devices implement the SUB_STATE subscription. We should either add this to the missing device or make the lightpath be a little more intelligent about subscribing to the _default_sub

Current Behavior

[2018-07-19 09:19:34] - ERROR - BeamPath is unable to subscribe to device fee_m1h
[2018-07-19 09:19:34] - ERROR - BeamPath is unable to subscribe to device fee_m2h
[2018-07-19 09:19:34] - ERROR - BeamPath is unable to subscribe to device xpp_attenuators
[2018-07-19 09:19:35] - ERROR - Widget is unable to subscribe to device fee_m1h
[2018-07-19 09:19:35] - ERROR - Widget is unable to subscribe to device fee_m2h
[2018-07-19 09:19:35] - ERROR - Widget is unable to subscribe to device xpp_attenuators
ZLLentz commented 6 years ago

This looks like all the devices that don't have a defined state

teddyrendahl commented 6 years ago

Lightpath is handling this issue correctly. All devices in the lightpath should have SUB_STATE