pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

ENH: Filter Options #76

Closed teddyrendahl closed 6 years ago

teddyrendahl commented 6 years ago

Description

A bunch of helpful navigation widget options. You can now:

I also implemented the upstream filter in the more general structure now. This means we only disconnect / reconnect to widgets when we switch beamlines. Avoid loading the entire beampath whenever possible!

Motivation and Context

Closes #73 Closes #67

How Has This Been Tested?

Added tests for all new functions

Screenshots (if appropriate):

screen shot 2018-07-19 at 4 26 01 pm
codecov-io commented 6 years ago

Codecov Report

Merging #76 into master will increase coverage by 0.95%. The diff coverage is 96.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   87.72%   88.68%   +0.95%     
==========================================
  Files           7        7              
  Lines         391      433      +42     
==========================================
+ Hits          343      384      +41     
- Misses         48       49       +1
Impacted Files Coverage Δ
lightpath/ui/widgets.py 87.71% <100%> (ø) :arrow_up:
lightpath/ui/gui.py 95.65% <96.55%> (+0.86%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3413dd5...1a81ac2. Read the comment docs.

teddyrendahl commented 6 years ago

Fixed the imports, added a test. Nothing too controversial. Will merge if no complaints.

ZLLentz commented 6 years ago

:+1: