search

pcdshub / lightpath

LCLS Lightpath Module
https://pcdshub.github.io/lightpath
Other
4 stars 9 forks source link

ENH: Hint Display #89

Closed teddyrendahl closed 5 years ago

teddyrendahl commented 5 years ago

Description

Replace the generic insert and remove commands with Device hints. Uses typhon utilities only available in the latest 0.2.1 release.

Motivation and Context

Closes #58 Closes #74

How Has This Been Tested?

Simulated devices now have hints. Explicit test added that checks that these are added correctly

Screenshots (if appropriate):

screen shot 2018-09-28 at 2 29 12 pm
codecov-io commented 5 years ago

Codecov Report

Merging #89 into master will decrease coverage by 0.3%. The diff coverage is 80.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   89.57%   89.26%   -0.31%     
==========================================
  Files           7        7              
  Lines         518      531      +13     
==========================================
+ Hits          464      474      +10     
- Misses         54       57       +3
Impacted Files Coverage Δ
lightpath/ui/gui.py 93.54% <70%> (-1.46%) :arrow_down:
lightpath/ui/widgets.py 93.26% <84.61%> (+0.48%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b60c376...7455821. Read the comment docs.