Closed ZLLentz closed 4 years ago
TODO: oops I started from the wrong commit
Rebase doesn't look bad, at least...
I'm assuming that what happened is that I started from an old commit without realizing it and spent a ton of time redoing work that has already been done. I'll untangle this today.
Rebased and confirmed my previous comment. This looks clean now. Remember to never rush to write code, you'll make mistakes and waste time.
Merging #98 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 89.16% 89.16%
=======================================
Files 7 7
Lines 526 526
=======================================
Hits 469 469
Misses 57 57
Impacted Files | Coverage Δ | |
---|---|---|
lightpath/ui/widgets.py | 93.26% <100%> (ø) |
:arrow_up: |
lightpath/ui/gui.py | 93.37% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c98138c...dd4f94a. Read the comment docs.
Description
Make it work with newest Typhos (renamed Typhon).